build: upgrade codecov from v3 to v4, use secret #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdmccormick
changed the title
|
Hm, the Run Coverage step says: |
|
There is a second file that uses codecov too, manual-publish.yml |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #692 +/- ##
==========================================
- Coverage 83.50% 83.41% -0.10%
==========================================
Files 40 40
Lines 1073 1073
Branches 197 197
==========================================
- Hits 896 895 -1
- Misses 165 166 +1
Partials 12 12 ☔ View full report in Codecov by Sentry. |
kdmccormick
force-pushed
the
kdmccormick/codecov-v4
branch
from
41816d3 to
877f51f
Compare
|
@dcoa how does this look? |
dcoa
approved these changes
May 15, 2024
bra-i-am
pushed a commit
to eduNEXT/frontend-platform
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://openedx.atlassian.net/wiki/spaces/COMM/pages/3438280709/Adding+Codecov, I think this is the right thing to do.
@dcoa , could you review this?